[webkit-reviews] review granted: [Bug 217422] Qualify PlatformDisplayID with WebCore:: in WebViewImpl : [Attachment 410731] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 6 21:45:03 PDT 2020


Darin Adler <darin at apple.com> has granted Saagar Jha <saagar at saagarjha.com>'s
request for review:
Bug 217422: Qualify PlatformDisplayID with WebCore:: in WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=217422

Attachment 410731: Patch

https://bugs.webkit.org/attachment.cgi?id=410731&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 410731
  --> https://bugs.webkit.org/attachment.cgi?id=410731
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410731&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2201
> +    WebCore::PlatformDisplayID displayID =
WebCore::displayID(window.screen);

I suggest we use auto here instead.


More information about the webkit-reviews mailing list