[webkit-reviews] review granted: [Bug 197158] Using CSS wide keywords as a fallback for variable substitution works inconsistently. : [Attachment 410678] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tyler Wilcock
<twilco.o at protonmail.com>'s request for review:
Bug 197158: Using CSS wide keywords as a fallback for variable substitution
works inconsistently.
https://bugs.webkit.org/show_bug.cgi?id=197158

Attachment 410678: Patch

https://bugs.webkit.org/attachment.cgi?id=410678&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 410678
  --> https://bugs.webkit.org/attachment.cgi?id=410678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410678&action=review

>> Source/WebCore/css/parser/CSSPropertyParser.cpp:296
>> +	if (value)
> 
> Can value ever be null here?

It can’t and this if statement can be removed.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:304
> +    if (RefPtr<CSSValue> value = maybeConsumeCSSWideKeyword(parser.m_range))

auto

> Source/WebCore/css/parser/CSSPropertyParser.cpp:369
> +    RefPtr<CSSValue> value = maybeConsumeCSSWideKeyword(rangeCopy);

auto