[webkit-reviews] review granted: [Bug 217405] Add implementation for AudioWorkletGlobalScope.registerProcessor() : [Attachment 410693] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217405: Add implementation for AudioWorkletGlobalScope.registerProcessor()
https://bugs.webkit.org/show_bug.cgi?id=217405

Attachment 410693: Patch

https://bugs.webkit.org/attachment.cgi?id=410693&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 410693
  --> https://bugs.webkit.org/attachment.cgi?id=410693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410693&action=review

r=me

> Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp:70
> +    JSC::JSObject* jsConstructor =
processorContructor->callbackData()->callback();
> +    auto* globalObject = jsConstructor->globalObject();
> +    auto& vm = globalObject->vm();
> +    auto scope = DECLARE_THROW_SCOPE(vm);

Does an audio worklet always execute on the same non-main thread?