[webkit-reviews] review granted: [Bug 217251] Add implementation for AudioWorkletGlobalScope's currentFrame / currentTime / sampleRate attributes : [Attachment 410654] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217251: Add implementation for AudioWorkletGlobalScope's currentFrame /
currentTime / sampleRate attributes
https://bugs.webkit.org/show_bug.cgi?id=217251

Attachment 410654: Patch

https://bugs.webkit.org/attachment.cgi?id=410654&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 410654
  --> https://bugs.webkit.org/attachment.cgi?id=410654
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410654&action=review

r=me

> Source/WebCore/Modules/webaudio/AudioDestinationNode.cpp:105
> +	   if (auto* audioWorkletGlobalScope =
audioWorkletProxy->workletThread().globalScope())

Maybe workletThread().globalScope() should encode this comment as an ASSERT or
as a RELEASE_ASSERT.