[webkit-reviews] review granted: [Bug 217402] [LFC][BFC] Move document box special height computation out of contentHeightForFormattingContextRoot : [Attachment 410687] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 6 14:17:50 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 217402: [LFC][BFC] Move document box special height computation out of
contentHeightForFormattingContextRoot
https://bugs.webkit.org/show_bug.cgi?id=217402

Attachment 410687: Patch

https://bugs.webkit.org/attachment.cgi?id=410687&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 410687
  --> https://bugs.webkit.org/attachment.cgi?id=410687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410687&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:826
> +	   else if (layoutBox.isDocumentBox() &&
!layoutBox.establishesFormattingContext()) {

isDocumentElementBox


More information about the webkit-reviews mailing list