[webkit-reviews] review denied: [Bug 217309] [GTK][WPE] Switch to unprefixed WebAudio API : [Attachment 410632] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied  review:
Bug 217309: [GTK][WPE] Switch to unprefixed WebAudio API
https://bugs.webkit.org/show_bug.cgi?id=217309

Attachment 410632: Patch

https://bugs.webkit.org/attachment.cgi?id=410632&action=review




--- Comment #7 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 410632
  --> https://bugs.webkit.org/attachment.cgi?id=410632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410632&action=review

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:2742
> +    priv->preferences->setModernUnprefixedWebAudioEnabled(enabled);

This should be unneeded, as pointed by Sam there is the following in
“Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml”:

  ModernUnprefixedWebAudioEnabled:
    type: bool
    humanReadableName: "Modern WebAudio API"
    humanReadableDescription: "Modern and unprefixed WebAudio API"
    condition: ENABLE(WEB_AUDIO)
    defaultValue:
      WebKitLegacy:
	"PLATFORM(IOS_FAMILY)" : true
	default: false
      WebKit:
	default: true

Note how this is enabled by default :)