[webkit-reviews] review granted: [Bug 217389] [Cocoa] The WebContent development XPC service is not allowed to connect to the XPC endpoint in the Networking process : [Attachment 410670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 6 11:48:43 PDT 2020


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 217389: [Cocoa] The WebContent development XPC service is not allowed to
connect to the XPC endpoint in the Networking process
https://bugs.webkit.org/show_bug.cgi?id=217389

Attachment 410670: Patch

https://bugs.webkit.org/attachment.cgi?id=410670&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 410670
  --> https://bugs.webkit.org/attachment.cgi?id=410670
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410670&action=review

r=me

> Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:33
> +#import <wtf/text/WTFString.h>

Should most of these things be inside PLATFORM(MAC), since they only seem to be
used in that build case?


More information about the webkit-reviews mailing list