[webkit-reviews] review denied: [Bug 217072] Add WKContentWorld declarations required by _WKUserStyleSheet : [Attachment 409940] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has denied  review:
Bug 217072: Add WKContentWorld declarations required by _WKUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=217072

Attachment 409940: Patch

https://bugs.webkit.org/attachment.cgi?id=409940&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 409940
  --> https://bugs.webkit.org/attachment.cgi?id=409940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409940&action=review

> Source/WebKit/ChangeLog:12
> +	   _WKUserStyleSheet uses WKContentWorld, but doesn't import it
specifically. In the unified
> +	   build, _WKUserContentWorld.mm (which transitively includes the
header that defines
> +	   WKContentWorld) is listed two lines above _WKUserStyleSheet.mm,
which often means that this
> +	   issue gets hidden if the split occurs such that they end up in the
same compilation unit.
> +	   This change should allow the build to work regardless of whether the
files end up together.
> +
> +	   Add WKContentWorld declarations required by _WKUserStyleSheet
> +	   https://bugs.webkit.org/show_bug.cgi?id=217072
> +
> +	   Reviewed by NOBODY (OOPS!).

Your changelog is not quite in the right order! Look at other examples; it goes

Title
Bug

Reviewed By

Description

File List