[webkit-reviews] review granted: [Bug 217333] FileReader should transition to readyState DONE after last onprogress event : [Attachment 410640] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 217333: FileReader should transition to readyState DONE after last
onprogress event
https://bugs.webkit.org/show_bug.cgi?id=217333

Attachment 410640: Patch

https://bugs.webkit.org/attachment.cgi?id=410640&action=review




--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 410640
  --> https://bugs.webkit.org/attachment.cgi?id=410640
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410640&action=review

> Source/WebCore/ChangeLog:8
> +	   I also bring the abort function in alignment with
https://www.w3.org/FileAPI/#abort

Let's replace with https://w3c.github.io/FileAPI/.

> Source/WebCore/fileapi/FileReader.cpp:160
> +    ASSERT(m_state != DONE);

ASSERT not needed anymore

> Source/WebCore/fileapi/FileReader.cpp:168
> +    fireEvent(eventNames().loadendEvent);

The spec says:
If context object's state is not "loading", fire a progress event called
loadend at the context object.
I do not really see how that could happen in practice. Maybe the spec could be
simplified.