[webkit-reviews] review granted: [Bug 217366] Align URL setters with reasonably behaving other browsers : [Attachment 410615] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 6 00:50:32 PDT 2020
youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 217366: Align URL setters with reasonably behaving other browsers
https://bugs.webkit.org/show_bug.cgi?id=217366
Attachment 410615: Patch
https://bugs.webkit.org/attachment.cgi?id=410615&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 410615
--> https://bugs.webkit.org/attachment.cgi?id=410615
Patch
LGTM.
Please update the two failing tests to match the new behavior.
View in context: https://bugs.webkit.org/attachment.cgi?id=410615&action=review
> Source/WTF/ChangeLog:10
> + I think these behaviors make sense, and aligning with these
behaviors makes it so there are no tests in url-setters.html
Do we have some spec language describing that? If not, can we file an issue?
More information about the webkit-reviews
mailing list