[webkit-reviews] review granted: [Bug 217331] Make value parameter in Document.execCommand non nullable : [Attachment 410547] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 217331: Make value parameter in Document.execCommand non nullable
https://bugs.webkit.org/show_bug.cgi?id=217331

Attachment 410547: Patch

https://bugs.webkit.org/attachment.cgi?id=410547&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 410547
  --> https://bugs.webkit.org/attachment.cgi?id=410547
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review

> Source/WebCore/dom/Document+HTML.idl:71
> +    [CEReactions] boolean execCommand(DOMString commandId, optional boolean
showUI = false, optional DOMString value = null);

I think the default value is supposed to be "". Are you planning to fix that in
a follow up? If you wanted to, you could just do them all at one.