[webkit-reviews] review granted: [Bug 217241] Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'breakpoint.disabled = true') : [Attachment 410351] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 217241: Web Inspector: Uncaught Exception: TypeError: undefined is not an
object (evaluating 'breakpoint.disabled = true')
https://bugs.webkit.org/show_bug.cgi?id=217241

Attachment 410351: Patch

https://bugs.webkit.org/attachment.cgi?id=410351&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 410351
  --> https://bugs.webkit.org/attachment.cgi?id=410351
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410351&action=review

r=e

>>>> Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701
>>>> -		     
target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId)
;
>>> 
>>> Why remove this call?
>> 
>> this is done later inside `_handleEventBreakpointDisabledStateChanged`
(which is an event listener callback for
`WI.Breakpoint.Event.DisabledStateDidChange`, which is dispatched by
`WI.Breakpoint.prototype.set disabled`)
> 
> Nice, thanks for explaining!

Would have been good to put this in the changelog :-)