[webkit-reviews] review granted: [Bug 217298] [curl] WebSocket tests are failing since r267931 : [Attachment 410491] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 217298: [curl] WebSocket tests are failing since r267931
https://bugs.webkit.org/show_bug.cgi?id=217298

Attachment 410491: Patch

https://bugs.webkit.org/attachment.cgi?id=410491&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 410491
  --> https://bugs.webkit.org/attachment.cgi?id=410491
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410491&action=review

> Source/WebCore/platform/network/curl/CurlStream.cpp:47
>      // Libcurl is not responsible for the protocol handling. It just handles
connection.
>      // Only scheme, host and port is required.
> -    URL urlForConnection;
> -    urlForConnection.setProtocol(url.protocolIs("wss") ? "https" : "http");
> -    urlForConnection.setHostAndPort(url.hostAndPort());
> -    m_curlHandle->setUrl(urlForConnection);
> +    url.setProtocol(url.protocolIs("wss") ? "https" : "http");
> +    m_curlHandle->setUrl(WTFMove(url));

The code no longer matches the comment.