[webkit-reviews] review granted: [Bug 217300] Remove support for enabling subpixel CSSOM values, it's off by default everywhere and known to be not-compatible with the web : [Attachment 410488] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 217300: Remove support for enabling subpixel CSSOM values, it's off by
default everywhere and known to be not-compatible with the web
https://bugs.webkit.org/show_bug.cgi?id=217300

Attachment 410488: Patch

https://bugs.webkit.org/attachment.cgi?id=410488&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 410488
  --> https://bugs.webkit.org/attachment.cgi?id=410488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410488&action=review

> Source/WebCore/dom/Element.cpp:1057
> +    result.adjustedValue = result.zoomFactor == 1 ? value.toDouble() :
value.toDouble() / result.zoomFactor;

Surely just dividing by 1 is faster than the test.

> Source/WebCore/dom/Element.cpp:1082
> +    LayoutUnit offsetLeft = LayoutUnit(roundToInt(offset));

auto offsetLeft = LayoutUnit { roundToInt(offset) } ?

> Source/WebCore/dom/Element.cpp:1157
> +	   LayoutUnit offsetWidth =
LayoutUnit(roundToInt(renderer->offsetWidth()));

Ditto

> Source/WebCore/dom/Element.cpp:1167
> +	   LayoutUnit offsetHeight =
LayoutUnit(roundToInt(renderer->offsetHeight()));

Ditto

> Source/WebCore/dom/Element.cpp:1200
> +	   LayoutUnit clientLeft =
LayoutUnit(roundToInt(renderer->clientLeft()));

ditto

> Source/WebCore/dom/Element.cpp:1211
> +	   LayoutUnit clientTop =
LayoutUnit(roundToInt(renderer->clientTop()));

ditto

> Source/WebCore/dom/Element.cpp:1234
>	   // clientWidth/Height is the visual portion of the box content, not
including

ditto

> Source/WebCore/dom/Element.cpp:1266
> +	   LayoutUnit clientHeight =
LayoutUnit(roundToInt(renderer->clientHeight()));

ditto