[webkit-reviews] review granted: [Bug 217239] Unify linkedOnOrAfter duplicate code and use SPI/WebCoreTestSupport instead of NSUserDefaults : [Attachment 410447] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 217239: Unify linkedOnOrAfter duplicate code and use SPI/WebCoreTestSupport
instead of NSUserDefaults
https://bugs.webkit.org/show_bug.cgi?id=217239

Attachment 410447: Patch

https://bugs.webkit.org/attachment.cgi?id=410447&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 410447
  --> https://bugs.webkit.org/attachment.cgi?id=410447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410447&action=review

> Tools/TestWebKitAPI/mac/mainMac.mm:55
> +#ifndef BUILDING_TEST_WTF
> +    [WKProcessPool _setLinkedOnOrAfterEverythingForTesting];
> +#endif

This doesn’t really belong, here, between the dictionary used for
NSUserDefaults, and the method call for NSUserDefaults. I'd move it down a
little bit, until after the NSUserDefaults code.