[webkit-reviews] review granted: [Bug 217291] Add non-animated support for the CSS scale property : [Attachment 410475] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 217291: Add non-animated support for the CSS scale property
https://bugs.webkit.org/show_bug.cgi?id=217291

Attachment 410475: Patch

https://bugs.webkit.org/attachment.cgi?id=410475&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 410475
  --> https://bugs.webkit.org/attachment.cgi?id=410475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410475&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:643
> +    if (!rendererCanBeTransformed(renderer) || is<RenderInline>(*renderer)
|| !scale)

Doesn't rendererCanBeTransformed() check is<RenderInline>?

> Source/WebCore/css/CSSProperties.json:6497
> +		   "url":
"https://drafts.csswg.org/css-transforms-2/#propdef-translate"

Wrong url.

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:182
> +    RefPtr<ScaleTransformOperation> scale;

StyleRareNonInheritedData is growing...