[webkit-reviews] review granted: [Bug 216972] Calling suspend() on audio context with no node does not prevent auto transition to running when first node is created : [Attachment 410359] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 216972: Calling suspend() on audio context with no node does not prevent
auto transition to running when first node is created
https://bugs.webkit.org/show_bug.cgi?id=216972

Attachment 410359: Patch

https://bugs.webkit.org/attachment.cgi?id=410359&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 410359
  --> https://bugs.webkit.org/attachment.cgi?id=410359
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410359&action=review

> Source/WebCore/Modules/webaudio/BaseAudioContext.h:467
> +    bool m_wasSuspendedByUser { false };

What is "user" here? Code in the webpage? Not sure the word "user" is quite
right for that, unless it’s guarded by "in response to user event" or that sort
of thing.