[webkit-reviews] review granted: [Bug 217194] Add stubs for AudioWorkletProcessor and AudioWorkletGlobalScope : [Attachment 410298] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217194: Add stubs for AudioWorkletProcessor and AudioWorkletGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=217194

Attachment 410298: Patch

https://bugs.webkit.org/attachment.cgi?id=410298&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 410298
  --> https://bugs.webkit.org/attachment.cgi?id=410298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410298&action=review

What's the deal with all the extra "DOM"s added to the generated code? Name
conflict? Can you add an explanation to the changelog?

> Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.h:53
> +    float sampleRate() const { return 44100; }

This number should probably be in its own constexpr with a clear name to
explain it (unless you expect this to go away real soon).

> Source/WebCore/Modules/webaudio/AudioWorkletProcessorConstructor.idl:31
> +]callback AudioWorkletProcessorConstructor = AudioWorkletProcessor (object
options);

Please add a space after the closing ].