[webkit-reviews] review denied: [Bug 68089] WebKit doesn't parse "#" as delimiter for fragment identifier in data URIs : [Attachment 410304] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 68089: WebKit doesn't parse "#" as delimiter for fragment identifier in
data URIs
https://bugs.webkit.org/show_bug.cgi?id=68089

Attachment 410304: Patch

https://bugs.webkit.org/attachment.cgi?id=410304&action=review




--- Comment #67 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 410304
  --> https://bugs.webkit.org/attachment.cgi?id=410304
Patch

WebKitTestRunner and DumpRenderTree use NSUserDefaults instead of SPI to test
behavior of an app that is linked on or after everything, and Safari (even on
older macOS) behaves as if it were linked on the most recent SDK.  This is not
an issue for Safari View Controller, which is always actually linked with the
most recent SDK.
The linkedOnOrAfter implementation is basically duplicate code in WebKitLegacy
and WebKit that we need to use here in WebCore.  I was trying to make a minimal
change to get that working, but I think it would be even better if I unified
linkedOnOrAfter, used SPI instead of NSUserDefaults, and moved it to WebCore in
a separate patch before this change.