[webkit-reviews] review granted: [Bug 206118] [GPU Process] Support drawing text in 2D canvas with font features : [Attachment 410269] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 1 14:41:03 PDT 2020
Wenson Hsieh <wenson_hsieh at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 206118: [GPU Process] Support drawing text in 2D canvas with font features
https://bugs.webkit.org/show_bug.cgi?id=206118
Attachment 410269: Patch
https://bugs.webkit.org/attachment.cgi?id=410269&action=review
--- Comment #13 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 410269
--> https://bugs.webkit.org/attachment.cgi?id=410269
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=410269&action=review
> Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h:31
> +
Nit - stray whitespace.
> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:1185
> + encoder << static_cast<uint8_t>(font->origin());
Nit - do we need all these static casts? IIRC for enums that have an explicit
bit width, our Encoder/Decoders should know how to encode/decode them, so on
the decoding side we can just have `Optional<Origin>`.
More information about the webkit-reviews
mailing list