[webkit-reviews] review denied: [Bug 217156] Text gets clobbered when assigning to input.defaultValue : [Attachment 410187] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Joey Arhar
<jarhar at chromium.org>'s request for review:
Bug 217156: Text gets clobbered when assigning to input.defaultValue
https://bugs.webkit.org/show_bug.cgi?id=217156

Attachment 410187: Patch

https://bugs.webkit.org/attachment.cgi?id=410187&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 410187
  --> https://bugs.webkit.org/attachment.cgi?id=410187
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410187&action=review

Mechanical r- because we need to have a regression test that's checked in to
the repository to go from failing to passing state.

> Source/WebCore/ChangeLog:13
> +	  
https://wpt.fyi/results/html/semantics/forms/the-input-element/defaultValue-clo
bbering.html

Looks like we have this test imported:
https://trac.webkit.org/browser/webkit/trunk/LayoutTests/imported/w3c/web-platf
orm-tests/html/semantics/forms/the-input-element/defaultValue-clobbering.html

But it is already passing:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platfo
rm-tests%2Fhtml%2Fsemantics%2Fforms%2Fthe-input-element%2FdefaultValue-clobberi
ng.html

This is a reftest, so not sure what this means in the context of this fix.