[webkit-reviews] review denied: [Bug 217176] [CMake] unused variable warning spam in UIScriptController.h : [Attachment 410219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 1 09:08:41 PDT 2020

Ryosuke Niwa <rniwa at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 217176: [CMake] unused variable warning spam in UIScriptController.h

Attachment 410219: Patch


--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 410219
  --> https://bugs.webkit.org/attachment.cgi?id=410219

We don't want to do this. Just get rid of the used variables from function
definitions, not declarations. There are plenty of examples of this elsewhere
in WebKit

More information about the webkit-reviews mailing list