[webkit-reviews] review granted: [Bug 190668] Introduce ReflectApplyFunctionCallDotNode to optimize Reflect.apply : [Attachment 408382] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 190668: Introduce ReflectApplyFunctionCallDotNode to optimize Reflect.apply
https://bugs.webkit.org/show_bug.cgi?id=190668

Attachment 408382: Patch

https://bugs.webkit.org/attachment.cgi?id=408382&action=review




--- Comment #14 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 408382
  --> https://bugs.webkit.org/attachment.cgi?id=408382
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408382&action=review

r=me

> Source/JavaScriptCore/ChangeLog:17
> +	   To accomodate monkey-patching, Reflect.apply is exposed via
@globalPrivate

accomodate => accommodate

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:2001
> +RegisterID* ReflectApplyFunctionCallDotNode::emitBytecode(BytecodeGenerator&
generator, RegisterID* dst)

I wonder if we can somehow abstract this function to deal with all the variants
that are doing similar things.