[webkit-reviews] review granted: [Bug 219372] [iOS] <button> with multi-line content does not render properly : [Attachment 415065] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 30 15:10:26 PST 2020
Darin Adler <darin at apple.com> has granted Aditya Keerthi <akeerthi at apple.com>'s
request for review:
Bug 219372: [iOS] <button> with multi-line content does not render properly
https://bugs.webkit.org/show_bug.cgi?id=219372
Attachment 415065: Patch
https://bugs.webkit.org/attachment.cgi?id=415065&action=review
--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 415065
--> https://bugs.webkit.org/attachment.cgi?id=415065
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=415065&action=review
> Source/WebCore/rendering/RenderThemeIOS.mm:1031
> + style.setMinHeight(Length(static_cast<int>(ControlBaseHeight /
ControlBaseFontSize * style.fontDescription().computedSize()), Fixed));
Is it good to still be doing a floor operation here (static_cast<int>) rather
than a rounding or a ceiling operation?
More information about the webkit-reviews
mailing list