[webkit-reviews] review granted: [Bug 218804] sessionStorage should not be cloned when a window is opened with rel=noopener : [Attachment 415047] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 218804: sessionStorage should not be cloned when a window is opened with
rel=noopener
https://bugs.webkit.org/show_bug.cgi?id=218804

Attachment 415047: Patch

https://bugs.webkit.org/attachment.cgi?id=415047&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 415047
  --> https://bugs.webkit.org/attachment.cgi?id=415047
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415047&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SessionStorage.mm:54
> +- (void)webView:(WKWebView *)webView
runJavaScriptConfirmPanelWithMessage:(NSString *)message
initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(BOOL
result))completionHandler

TestUIDelegate has waitForAlert.  We could so something similar instead of
making another global done boolean that prevents us from unifying sources.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SessionStorage.mm:67
> +    sharedUIDelegate = adoptNS([[SessionStorageUIDelegate alloc] init]);

This could just be a function-scoped static variable.