[webkit-reviews] review granted: [Bug 217315] Lazy loaded iframe should not lazy load when scripting is disabled : [Attachment 414990] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 217315: Lazy loaded iframe should not lazy load when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=217315

Attachment 414990: Patch

https://bugs.webkit.org/attachment.cgi?id=414990&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 414990
  --> https://bugs.webkit.org/attachment.cgi?id=414990
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414990&action=review

> Source/WebCore/html/HTMLIFrameElement.cpp:172
> +    if (!document.frame() ||
!document.frame()->script().canExecuteScripts(NotAboutToExecuteScript))

Can we find a way to share this expression with
HTMLImageElement::isLazyLoadable? Null check on frame makes this expression
long enough that it seems worth while. Maybe.