[webkit-reviews] review canceled: [Bug 219288] aarch64 llint does not build with JIT disabled : [Attachment 414869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 25 15:13:44 PST 2020


Michael Catanzaro <mcatanzaro at gnome.org> has canceled Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 219288: aarch64 llint does not build with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=219288

Attachment 414869: Patch

https://bugs.webkit.org/attachment.cgi?id=414869&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 414869
  --> https://bugs.webkit.org/attachment.cgi?id=414869
Patch

Hm, there are even more problems, let me fix them all in one patch.

Next problem is:

../Source/JavaScriptCore/assembler/LinkBuffer.cpp: In member function 'void
JSC::LinkBuffer::copyCompactAndLinkCode(JSC::MacroAssembler&,
JSC::JITCompilationEffort)':
../Source/JavaScriptCore/assembler/LinkBuffer.cpp:380:13: error: there are no
arguments to 'dumpJITMemory' that depend on a template parameter, so a
declaration of 'dumpJITMemory' must be available [-fpermissive]
	     dumpJITMemory(outData, outData, m_size);
	     ^~~~~~~~~~~~~
../Source/JavaScriptCore/assembler/LinkBuffer.cpp:380:13: note: (if you use
'-fpermissive', G++ will accept your code, but allowing the use of an
undeclared name is deprecated)
../Source/JavaScriptCore/assembler/LinkBuffer.cpp: In instantiation of 'void
JSC::LinkBuffer::copyCompactAndLinkCode(JSC::MacroAssembler&,
JSC::JITCompilationEffort) [with InstructionType = unsigned int]':
../Source/JavaScriptCore/assembler/LinkBuffer.cpp:423:60:   required from here
../Source/JavaScriptCore/assembler/LinkBuffer.cpp:380:26: error:
'dumpJITMemory' was not declared in this scope
	     dumpJITMemory(outData, outData, m_size);
	     ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~


More information about the webkit-reviews mailing list