[webkit-reviews] review granted: [Bug 219256] GraphicsContextGL should have robust multivalue setters : [Attachment 414840] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 219256: GraphicsContextGL should have robust multivalue setters
https://bugs.webkit.org/show_bug.cgi?id=219256

Attachment 414840: Patch

https://bugs.webkit.org/attachment.cgi?id=414840&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 414840
  --> https://bugs.webkit.org/attachment.cgi?id=414840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414840&action=review

Very nice.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1132
> -    m_context->getExtensions().texImage2DRobustANGLE(target, level,
internalformat, width, height, border, format, type, 0,
reinterpret_cast<void*>(offset));
> +    m_context->texImage2D(target, level, internalformat, width, height,
border, format, type, offset);

Was this intentional? Does texImage2D call the robust ANGLE form itself?