[webkit-reviews] review granted: [Bug 218954] [JSC] Add wasm atomics instructions : [Attachment 414795] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 218954: [JSC] Add wasm atomics instructions
https://bugs.webkit.org/show_bug.cgi?id=218954

Attachment 414795: Patch

https://bugs.webkit.org/attachment.cgi?id=414795&action=review




--- Comment #13 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 414795
  --> https://bugs.webkit.org/attachment.cgi?id=414795
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414795&action=review

Super nice!

> Source/JavaScriptCore/b3/B3Width.h:116
> +    return 1U << static_cast<unsigned>(width);

Slight preference for this being a switch.  It's clearer and less sensitive to
the enum being messed with.

> Source/JavaScriptCore/b3/testb3_8.cpp:593
> +	       // AtomicXchg can be lowered to "xchg" without "lock", and this
is OK since "lock" signal is asserted for "xchg" by default.

Oh really?  I thought that xchg only created a fence by default, but not the
lock.