[webkit-reviews] review granted: [Bug 219257] [GTK] Allow WebKitTestServer to run non-localhost addresses for API tests : [Attachment 414801] Tentative patch (untested)

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 219257: [GTK] Allow WebKitTestServer to run non-localhost addresses for API
tests
https://bugs.webkit.org/show_bug.cgi?id=219257

Attachment 414801: Tentative patch (untested)

https://bugs.webkit.org/attachment.cgi?id=414801&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 414801
  --> https://bugs.webkit.org/attachment.cgi?id=414801
Tentative patch (untested)

View in context: https://bugs.webkit.org/attachment.cgi?id=414801&action=review

LGTM. I see TestSSL now needs two HTTP servers instead of one, but that's fine.

I bet Carlos Garcia will want to review this before it lands.

> Tools/TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:38
> -    WebKitTestServer(ServerOptions = ServerHTTP);
> +    WebKitTestServer(uint8_t options = ServerHTTP);

I don't like this... why are you removing its nice type?