[webkit-reviews] review granted: [Bug 218748] [GStreamer] refactor video encoder with WebKit style : [Attachment 413694] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 218748: [GStreamer] refactor video encoder with WebKit style
https://bugs.webkit.org/show_bug.cgi?id=218748

Attachment 413694: Patch

https://bugs.webkit.org/attachment.cgi?id=413694&action=review




--- Comment #4 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 413694
  --> https://bugs.webkit.org/attachment.cgi?id=413694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413694&action=review

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:39
> +    GST_STATIC_PAD_TEMPLATE ("src", GST_PAD_SRC, GST_PAD_ALWAYS,
GST_STATIC_CAPS ("video/x-h264;video/x-vp8;video/x-vp9"));

vp9 is added here, but I see no mention of a vp9enc below. Maybe add vp9 in a
follow-up patch, if this patch is meant to be a refactoring only.