[webkit-reviews] review granted: [Bug 218855] Implement audio capture for SpeechRecognition on macOS : [Attachment 414756] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted  review:
Bug 218855: Implement audio capture for SpeechRecognition on macOS
https://bugs.webkit.org/show_bug.cgi?id=218855

Attachment 414756: Patch

https://bugs.webkit.org/attachment.cgi?id=414756&action=review




--- Comment #43 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 414756
  --> https://bugs.webkit.org/attachment.cgi?id=414756
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414756&action=review

> Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.cpp:91
> +	       invokeStateUpdateCallback(SpeechRecognitionUpdateType::Error,
"Unable to set input format");

Let's use an explicit callOnMainThread here so that we do not need to go in the
business of using isolatedCopy.
We could add to invokeStateUpdateCallback an ASSERT(isMainThread());

> Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.cpp:96
> +	       invokeStateUpdateCallback(SpeechRecognitionUpdateType::Error,
"Unable to set output format");

Ditto