[webkit-reviews] review granted: [Bug 219220] [LFC][Integration] Add contentOffset and contentWidth to Line : [Attachment 414739] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 219220: [LFC][Integration] Add contentOffset and contentWidth to Line
https://bugs.webkit.org/show_bug.cgi?id=219220

Attachment 414739: Patch

https://bugs.webkit.org/attachment.cgi?id=414739&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 414739
  --> https://bugs.webkit.org/attachment.cgi?id=414739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414739&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLine.h:53
> +	   , m_contentLeftOffset(contentLeftOffset)
> +	   , m_contentWidth(contentWidth)

Could the client just do

content.runs[line.firstRunIndex()].rect().x()
etc

to get the same numbers? I guess having a redundant copy here doesn't hurt.