[webkit-reviews] review granted: [Bug 219201] Poor resampling quality when using AudioContext sampleRate parameter : [Attachment 414734] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 219201: Poor resampling quality when using AudioContext sampleRate
parameter
https://bugs.webkit.org/show_bug.cgi?id=219201

Attachment 414734: Patch

https://bugs.webkit.org/attachment.cgi?id=414734&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 414734
  --> https://bugs.webkit.org/attachment.cgi?id=414734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414734&action=review

r=me

> Source/WebCore/ChangeLog:14
> +	   called than once per channel and this resulted in very poor
resampling quality.

called than => called more than

> Source/WebCore/platform/audio/MultiChannelResampler.cpp:65
>      void provideInput(AudioBus* bus, size_t framesToProcess) override

I feel like setCurrentChannel() and m_currentChannel should just go away; and
instead we should pass currentChannel as an argument to this function.

Keeping m_currentChannel as state on the side is a bit of extra mental load,
and it invites our caller to call the two functions out of sync.