[webkit-reviews] review granted: [Bug 219103] [iOS][FCR] Add new look for meter element : [Attachment 414465] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 219103: [iOS][FCR] Add new look for meter element
https://bugs.webkit.org/show_bug.cgi?id=219103

Attachment 414465: Patch

https://bugs.webkit.org/attachment.cgi?id=414465&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 414465
  --> https://bugs.webkit.org/attachment.cgi?id=414465
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414465&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:2092
> +    auto* element = renderMeter.meterElement();

Nit - I /think/ we prefer RefPtr over raw pointers like this in new code (i.e.
auto element = makeRefPtr(renderMeter.meterElement());)