[webkit-reviews] review granted: [Bug 218893] [WebAuthn] Implement SPI for AuthenticationServices.Framework : [Attachment 414703] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 218893: [WebAuthn] Implement SPI for AuthenticationServices.Framework
https://bugs.webkit.org/show_bug.cgi?id=218893

Attachment 414703: Patch

https://bugs.webkit.org/attachment.cgi?id=414703&action=review




--- Comment #32 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 414703
  --> https://bugs.webkit.org/attachment.cgi?id=414703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414703&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.h:42
> + at property (nullable, nonatomic, copy) NSString *rpId;

I still think this would be better as relyingPartyIdentifier, which is also
mentioned in the spec in
https://www.w3.org/TR/webauthn/#relying-party-identifier
Crypto has too many terms of art that are two or three letter abbreviations.