[webkit-reviews] review granted: [Bug 218893] [WebAuthn] Implement SPI for AuthenticationServices.Framework : [Attachment 414703] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 20 12:59:23 PST 2020

Alex Christensen <achristensen at apple.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 218893: [WebAuthn] Implement SPI for AuthenticationServices.Framework

Attachment 414703: Patch


--- Comment #32 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 414703
  --> https://bugs.webkit.org/attachment.cgi?id=414703

View in context: https://bugs.webkit.org/attachment.cgi?id=414703&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.h:42
> + at property (nullable, nonatomic, copy) NSString *rpId;

I still think this would be better as relyingPartyIdentifier, which is also
mentioned in the spec in
Crypto has too many terms of art that are two or three letter abbreviations.

More information about the webkit-reviews mailing list