[webkit-reviews] review granted: [Bug 219173] [macOS] Adopt SPI to prevent establishing XPC connections to Launch Services : [Attachment 414676] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 219173: [macOS] Adopt SPI to prevent establishing XPC connections to Launch
Services
https://bugs.webkit.org/show_bug.cgi?id=219173

Attachment 414676: Patch

https://bugs.webkit.org/attachment.cgi?id=414676&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 414676
  --> https://bugs.webkit.org/attachment.cgi?id=414676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414676&action=review

> Source/WebKit/UIProcess/WebProcessProxy.cpp:280
> +    Optional<WebKit::SandboxExtension::Handle> extension;
> +#if PLATFORM(MAC)

Should add a blank line here to make the formatting match the function below.

> Source/WebKit/WebProcess/WebProcess.h:518
> +    void updateProcessName(Optional<WebKit::SandboxExtension::Handle> =
WTF::nullopt);

Why doesn’t this function take an rvalue reference?

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:451
> +    if (handle) {

Since Handle already has a null value, we do not need to use Optional<>. If we
used just Handle everywhere, not Optional<Handle>, and took out this null
check, the code would work fine. SandboxExtension::create already does nothing
and returns nullptr if you call it with a null Handle.