[webkit-reviews] review granted: [Bug 219141] [macOS] Add telemetry for things we believe are unused : [Attachment 414699] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 219141: [macOS] Add telemetry for things we believe are unused
https://bugs.webkit.org/show_bug.cgi?id=219141

Attachment 414699: Patch

https://bugs.webkit.org/attachment.cgi?id=414699&action=review




--- Comment #5 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 414699
  --> https://bugs.webkit.org/attachment.cgi?id=414699
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414699&action=review

R=me.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:121
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000

Does this rule already have telemetry?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:140
> +	   (with telemetry-backtrace)

Does this rule already have telemetry?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:174
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000

Does this rule also already have telemetry?