[webkit-reviews] review granted: [Bug 219164] [LFC][Integration] Remove ensureLineBoxes call from RenderedPosition constructor : [Attachment 414673] patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 219164: [LFC][Integration] Remove ensureLineBoxes call from
RenderedPosition constructor
https://bugs.webkit.org/show_bug.cgi?id=219164

Attachment 414673: patch

https://bugs.webkit.org/attachment.cgi?id=414673&action=review




--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 414673
  --> https://bugs.webkit.org/attachment.cgi?id=414673
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414673&action=review

> Source/WebCore/dom/Position.cpp:-1378
> -void Position::ensureLineBoxes() const
> -{
> -    auto node = deprecatedNode();
> -    if (!node)
> -	   return;
> -    auto renderer = node->renderer();
> -    if (!renderer)
> -	   return;
> -    auto* parent = renderer->parent();
> -    if (is<RenderBlockFlow>(parent))
> -	   downcast<RenderBlockFlow>(*parent).ensureLineBoxes();
> -}
> -

Nice!