[webkit-reviews] review granted: [Bug 219171] Turn on ENABLE_WEBXR for Cocoa : [Attachment 414629] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 219171: Turn on ENABLE_WEBXR for Cocoa
https://bugs.webkit.org/show_bug.cgi?id=219171

Attachment 414629: Patch

https://bugs.webkit.org/attachment.cgi?id=414629&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 414629
  --> https://bugs.webkit.org/attachment.cgi?id=414629
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414629&action=review

> Source/WebCore/Modules/webxr/WebXRRigidTransform.h:41
> +    WTF_MAKE_ISO_ALLOCATED_EXPORT(WebXRRigidTransform, WEBCORE_EXPORT);

Are these for WebKit's use, or just WebCoreTestSupport? If the latter, you can
WEBCORE_TESTSUPPORT_EXPORT

> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:20
> +#if ENABLE(WEBXR) && USE_OPENXR

should be USE(OPENXR), not USE_OPENXR. Ditto in a bunch of places.