[webkit-reviews] review denied: [Bug 218893] [WebAuthn] Implement SPI for AuthenticationServices.Framework : [Attachment 414619] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jiewen Tan <jiewen_tan at apple.com>'s
request for review:
Bug 218893: [WebAuthn] Implement SPI for AuthenticationServices.Framework
https://bugs.webkit.org/show_bug.cgi?id=218893

Attachment 414619: Patch

https://bugs.webkit.org/attachment.cgi?id=414619&action=review




--- Comment #18 from Darin Adler <darin at apple.com> ---
Comment on attachment 414619
  --> https://bugs.webkit.org/attachment.cgi?id=414619
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414619&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:495
> +    return result.get();

This is an overrelease. We are returning an object after destroying the
RetainPtr keeping it alive.

There are two possible solutions:

1) Change the return type to RetainPtr.
2) Use autorelease() instead of ptr().

I prefer solution (1).

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:543
> +    return result.get();

Same mistake again.