[webkit-reviews] review granted: [Bug 219159] [macOS] Issue sandbox extension to icon services when starting a drag operation : [Attachment 414578] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 219159: [macOS] Issue sandbox extension to icon services when starting a
drag operation
https://bugs.webkit.org/show_bug.cgi?id=219159

Attachment 414578: Patch

https://bugs.webkit.org/attachment.cgi?id=414578&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 414578
  --> https://bugs.webkit.org/attachment.cgi?id=414578
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414578&action=review

r=me, but please make sure you revoke the extensions in the early return case.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2834
>      bool shouldHandleEvent = true;

I think there is an early return in the "if !(shouldHandleEvent)" case. You
should probably add a revokeSandboxExtensions there, too.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:7060
> +Vector<RefPtr<SandboxExtension>>
WebPage::consumeSandboxExtensions(SandboxExtension::HandleArray&&
sandboxExtensions)

We do something similar-ish in
UserMediaProcessManager::revokeSandboxExtensionsIfNeeded. We might consider a
future bug to consolidate the logic.