[webkit-reviews] review granted: [Bug 219148] Add support for RTCRtpScriptTransform : [Attachment 414564] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 219148: Add support for RTCRtpScriptTransform
https://bugs.webkit.org/show_bug.cgi?id=219148

Attachment 414564: Patch

https://bugs.webkit.org/attachment.cgi?id=414564&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 414564
  --> https://bugs.webkit.org/attachment.cgi?id=414564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414564&action=review

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.cpp:117
> +	   m_backend = makeRef(backend);

You only set `m_backend` if `setupTransformer` fails?

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:174
> +	       auto value = isAudio ? toJS(&globalObject, &globalObject,
RTCEncodedAudioFrame::create(WTFMove(frame))) : toJS(&globalObject,
&globalObject, RTCEncodedAudioFrame::create(WTFMove(frame)));

Don’t you want to create a Video frame when `isAudio` is false?