[webkit-reviews] review granted: [Bug 169644] Add support for RTCPeerConnection.onicecandidateerror event : [Attachment 414605] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 169644: Add support for RTCPeerConnection.onicecandidateerror event
https://bugs.webkit.org/show_bug.cgi?id=169644

Attachment 414605: Patch

https://bugs.webkit.org/attachment.cgi?id=414605&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 414605
  --> https://bugs.webkit.org/attachment.cgi?id=414605
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414605&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:357
> +		   if (url.path().endsWithIgnoringASCIICase(".local") ||
!portAllowed(url)) {

It seems strange to me to be using path for host-like things here, but that's
how it works.

> Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:46
> +	   uint16_t errorCode;

May as well add { 0 } to prevent use of uninitialized memory.

> Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:67
> +    uint16_t m_errorCode;

ditto