[webkit-reviews] review granted: [Bug 219088] Enable font functions on OffscreenCanvas for main-thread : [Attachment 414566] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Lord
<clord at igalia.com>'s request for review:
Bug 219088: Enable font functions on OffscreenCanvas for main-thread
https://bugs.webkit.org/show_bug.cgi?id=219088

Attachment 414566: Patch

https://bugs.webkit.org/attachment.cgi?id=414566&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 414566
  --> https://bugs.webkit.org/attachment.cgi?id=414566
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414566&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:2255
> +String CanvasRenderingContext2DBase::font() const

This should be called fontStyle or something. It doesn't return a Font*

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:2484
> +#if USE(CG)

Sad to see #if USE(CG) here.

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:384
> +    // Therefore, all font operations must pass through the State.

Not clear from this comment what "the State" refers to.