[webkit-reviews] review granted: [Bug 219116] 'run-analysis' script should schedule retries for A/B tests even after analysis chart failure. : [Attachment 414488] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 17:54:10 PST 2020


Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 219116: 'run-analysis' script should schedule retries for A/B tests even
after analysis chart failure.
https://bugs.webkit.org/show_bug.cgi?id=219116

Attachment 414488: Patch

https://bugs.webkit.org/attachment.cgi?id=414488&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 414488
  --> https://bugs.webkit.org/attachment.cgi?id=414488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414488&action=review

> Websites/perf.webkit.org/tools/run-analysis.js:50
> +	   console.error(`Failed analyze measurement sets due to ${error}`);

Failed *to* analyze

> Websites/perf.webkit.org/tools/run-analysis.js:66
> +	   console.error(`Failed retry for test group due to ${error}`);

Failed *to retry test groups* due to


More information about the webkit-reviews mailing list