[webkit-reviews] review granted: [Bug 219117] Menu Bar support for app highlights in book. : [Attachment 414489] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 18 17:15:35 PST 2020
Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 219117: Menu Bar support for app highlights in book.
https://bugs.webkit.org/show_bug.cgi?id=219117
Attachment 414489: Patch
https://bugs.webkit.org/attachment.cgi?id=414489&action=review
--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 414489
--> https://bugs.webkit.org/attachment.cgi?id=414489
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=414489&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8612
> + [[UIMenuController sharedMenuController] setMenuItems:@[
addHighlightCurrentGroupItem.get(), addHighlightNewGroupItem.get()]];
Nit - maybe an extra space after `addHighlightNewGroupItem.get()` to balance
out the leading space after @[?
More information about the webkit-reviews
mailing list