[webkit-reviews] review granted: [Bug 219041] [macOS] Issue sandbox extension to Web Inspector service : [Attachment 414359] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 219041: [macOS] Issue sandbox extension to Web Inspector service
https://bugs.webkit.org/show_bug.cgi?id=219041

Attachment 414359: Patch

https://bugs.webkit.org/attachment.cgi?id=414359&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 414359
  --> https://bugs.webkit.org/attachment.cgi?id=414359
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414359&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:209
> +    if (!CFPreferencesGetAppIntegerValue(CFSTR("ShowDevelopMenu"),
CFSTR("com.apple.Safari.SandboxBroker"), nullptr))

It's a shame we couldn't reuse WIRRemoteInspectorEnabledKey here (i.e., define
this differently on non-IOS_FAMILY).

> Tools/MiniBrowser/MiniBrowser.entitlements:29
> +		<string>com.apple.Safari.SandboxBroker</string>

Do we need this for WebKitTestRunner?