[webkit-reviews] review granted: [Bug 219067] [Concurrent display lists] Add a way for display lists to partially replay : [Attachment 414486] Slightly simpler approach

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 16:25:50 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 219067: [Concurrent display lists] Add a way for display lists to partially
replay
https://bugs.webkit.org/show_bug.cgi?id=219067

Attachment 414486: Slightly simpler approach

https://bugs.webkit.org/attachment.cgi?id=414486&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 414486
  --> https://bugs.webkit.org/attachment.cgi?id=414486
Slightly simpler approach

View in context: https://bugs.webkit.org/attachment.cgi?id=414486&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:154
> +	   if (destination.isAccelerated())
> +	      
static_cast<AcceleratedRemoteImageBuffer&>(destination).submitDisplayList(*disp
layList);
> +	   else
> +	      
static_cast<UnacceleratedRemoteImageBuffer&>(destination).submitDisplayList(*di
splayList);

This is sad-making.


More information about the webkit-reviews mailing list