[webkit-reviews] review granted: [Bug 219098] Use override in generated bindings : [Attachment 414463] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 15:42:26 PST 2020

Yusuke Suzuki <ysuzuki at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 219098: Use override in generated bindings

Attachment 414463: Patch


--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 414463
  --> https://bugs.webkit.org/attachment.cgi?id=414463

View in context: https://bugs.webkit.org/attachment.cgi?id=414463&action=review

r=me with one suggestion.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3230
>	   push(@headerContent, "public:\n");

How about making `class ${exportMacro}JS${interfaceName}Owner` final too? I
don't think anyone is inheriting this class.

More information about the webkit-reviews mailing list